Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max_depth constraint from plugin listing/caching #3732

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Remove max_depth constraint from plugin listing/caching #3732

merged 2 commits into from
Nov 2, 2023
+40 −94

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Oct 28, 2023

  • update @plugin_cache so that it always changes whenever any addition/edit/removal of plugins occurs (including touch PLUGINS_DIR)
  • remove max_depth flag from download_plugin(), for consistency with how list_plugins() searches infinitely deep, if necessary, to find plugins

@brimoor brimoor mentioned this pull request Oct 28, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (3c67a71) 15.99% compared to head (9ed5f75) 15.97%.
Report is 9 commits behind head on release/v0.22.3.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           release/v0.22.3    #3732      +/-   ##
===================================================
- Coverage            15.99%   15.97%   -0.02%     
===================================================
  Files                  596      597       +1     
  Lines                73188    73246      +58     
  Branches               917      918       +1     
===================================================
  Hits                 11703    11703              
- Misses               61485    61543      +58
Flag Coverage Δ
app 15.97% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/packages/core/src/ga.ts 0.00% <0.00%> (ø)
app/packages/operators/src/OperatorCore.tsx 0.00% <0.00%> (ø)
app/packages/core/src/components/Modal/Looker.tsx 0.00% <0.00%> (ø)
...p/packages/core/src/components/Sidebar/Sidebar.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
app/packages/operators/src/state.ts 0.00% <0.00%> (ø)
app/packages/operators/src/hooks.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brimoor brimoor force-pushed the bugfix/plugin-cache branch from 145f64d to 8e9064d Compare November 1, 2023 21:44
imanjra
imanjra approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@imanjra imanjra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit ec9f28b into release/v0.22.3 Nov 2, 2023
@brimoor brimoor deleted the bugfix/plugin-cache branch November 2, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imanjra imanjra imanjra approved these changes

@ritch ritch Awaiting requested review from ritch

@kaixi-wang kaixi-wang Awaiting requested review from kaixi-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brimoor @imanjra