Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic groups modal updates #3209

Merged
merged 9 commits into from
Jun 23, 2023
Merged

Dynamic groups modal updates #3209

merged 9 commits into from
Jun 23, 2023

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Jun 16, 2023 •
edited
Loading

Updates modal data flow and hooks to include dynamic groups state. I have worked through the main changes, but still finalizing broken tests

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Jun 16, 2023
@benjaminpkane benjaminpkane self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 13.27% and project coverage change: -34.03 ⚠️

Comparison is base (1076810) 49.18% compared to head (d461711) 15.15%.

❗ Current head d461711 differs from pull request most recent head 0f15c66. Consider uploading reports for the commit 0f15c66 to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           release/v0.21.1    #3209       +/-   ##
====================================================
- Coverage            49.18%   15.15%   -34.03%     
====================================================
  Files                  230      563      +333     
  Lines                34478    68920    +34442     
  Branches               325      600      +275     
====================================================
- Hits                 16957    10444     -6513     
- Misses               17521    58476    +40955
Flag Coverage Δ
app 15.15% <13.27%> (-34.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/.eslintrc.js 0.00% <0.00%> (ø)
app/packages/app/src/Network.tsx 0.00% <0.00%> (ø)
app/packages/app/src/index.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Dataset.ts 0.00% <0.00%> (ø)
app/packages/core/src/Root/Datasets/Dataset.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
.../packages/core/src/components/Actions/Selected.tsx 0.00% <0.00%> (ø)
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Actions/similar/utils.ts 0.00% <0.00%> (ø)
...ages/core/src/components/ColorModal/ColorModal.tsx 0.00% <0.00%> (ø)
... and 56 more

... and 424 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benjaminpkane benjaminpkane marked this pull request as ready for review June 23, 2023 15:12
@benjaminpkane
Copy link
Contributor Author

benjaminpkane commented Jun 23, 2023 •
edited
Loading

Tests are reliably passing locally. Will circle back to failing tests after an RC.

@benjaminpkane benjaminpkane merged commit bf650d5 into release/v0.21.1 Jun 23, 2023
@benjaminpkane benjaminpkane deleted the bugfix/groups branch June 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashankaryal sashankaryal Awaiting requested review from sashankaryal

Assignees

@benjaminpkane benjaminpkane

Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminpkane @imanjra