Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish steps for docs website #2476

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Publish steps for docs website #2476

merged 5 commits into from
Jan 20, 2023

Conversation

benjaminpkane
Copy link
Contributor

Adds the publishing steps via gsutil to automate the release of docs updates. @brimoor is there a cloud storage service account secret we can use? Or I can create one. cc @findtopher

@benjaminpkane benjaminpkane self-assigned this Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023 •
edited
Loading

Codecov Report

Base: 50.15% // Head: 62.53% // Increases project coverage by +12.38% 🎉

Coverage data is based on head (b7aafb0) compared to base (115e57d).
Patch coverage: 7.69% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #2476       +/-   ##
============================================
+ Coverage    50.15%   62.53%   +12.38%     
============================================
  Files          228      249       +21     
  Lines        31445    42025    +10580     
  Branches       343      343               
============================================
+ Hits         15770    26282    +10512     
- Misses       15675    15743       +68
Flag Coverage Δ
app 50.14% <7.69%> (-0.01%) ⬇️
python 99.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/core/src/components/Actions/utils.tsx 40.79% <0.00%> (-0.83%) ⬇️
app/packages/state/src/recoil/atoms.ts 93.47% <100.00%> (+0.02%) ⬆️
tests/unittests/patches_tests.py 99.30% <0.00%> (ø)
tests/unittests/utils_tests.py 98.71% <0.00%> (ø)
tests/misc/selection_tests.py 90.00% <0.00%> (ø)
tests/unittests/dataset_tests.py 99.82% <0.00%> (ø)
tests/misc/torch_tests.py 60.34% <0.00%> (ø)
tests/ipc_tests.py 100.00% <0.00%> (ø)
tests/unittests/label_tests.py 95.65% <0.00%> (ø)
tests/unittests/evaluation_tests.py 99.80% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

brimoor
brimoor reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@brimoor brimoor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminpkane is there risk that a docs build would fail in the action that would cause an incomplete/corrupted version of the docs to be synced to docs.voxel51.com? Or am I over-analyzing?

I recommend creating new GCS creds specifically for this workflow, just to be proper.

@benjaminpkane
Copy link
Contributor Author

@benjaminpkane is there risk that a docs build would fail in the action that would cause an incomplete/corrupted version of the docs to be synced to docs.voxel51.com? Or am I over-analyzing?

I would consider it unlikely, but if we do want to roll back a re-upload should take less than a minute

brimoor
brimoor approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit bcf4666 into develop Jan 20, 2023
@benjaminpkane benjaminpkane deleted the docs-bucket branch January 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brimoor brimoor brimoor approved these changes

@findtopher findtopher Awaiting requested review from findtopher

Assignees

@benjaminpkane benjaminpkane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminpkane @brimoor