Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset routing #2327

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix dataset routing #2327

merged 1 commit into from
Nov 18, 2022

Conversation

benjaminpkane
Copy link
Contributor

@fiftyone/dataset has no router state, so the useSetView hook should only update a router state if it is present.

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Nov 18, 2022
@benjaminpkane benjaminpkane self-assigned this Nov 18, 2022
Copy link
Contributor

@imanjra imanjra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjaminpkane benjaminpkane merged commit cbc120f into develop Nov 18, 2022
@benjaminpkane benjaminpkane deleted the bugfix/routing branch November 18, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants