acknowledge wiki language for Shariff #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krabina
changed the title
|
this PR tries to set the language of Shariff to the language of the MediaWiki installation. If the wiki is in a language that Shariff does not know, it will ignore the setting and fallback to English. This is not perfect, because even better it would refer to the user language, not the Wiki installation language. But I did not manage to accomplish that... |
|
Thanks for the PR! I would prefer the |
make German language problem more generic
|
Closes #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not perfect, but acknowledges at least different de language versions (de-formal, de-AT, de-CH) in mediawiki to be mapped to "de" in Shariff.
Solves the problem better than #7
in reference to #6