Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jobflow CRD metadata.annotations: Too long error #3347

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

guoqinwill
Copy link
Contributor

@guoqinwill guoqinwill commented Mar 13, 2024

fix jobflow CRD metadata.annotations: Too long error。
It is caused after #3295 ,this modification refers to #3197

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2024
@guoqinwill guoqinwill force-pushed the fix-annotatin-too-long branch from 60ba82f to 00cbc33 Compare March 14, 2024 01:57
@lowang-bh
Copy link
Member

I remember this is fixed in #3197

guoqinwill added 2 commits March 18, 2024 16:45
Signed-off-by: guoqinwill <guoqinwill@163.com>
Signed-off-by: wangyang <wangyang8126@gmail.com>
Signed-off-by: guoqinwill <guoqinwill@163.com>
@guoqinwill guoqinwill force-pushed the fix-annotatin-too-long branch from be9dbb4 to f766e4c Compare March 18, 2024 08:45
@Monokaix
Copy link
Member

I remember this is fixed in #3197

That pr fixed vcjob, here we fixed the jobflow resource.

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,just wondering what is the length limit

@guoqinwill
Copy link
Contributor Author

LGTM,just wondering what is the length limit

may be like this:#3107

@Monokaix
Copy link
Member

/lgtm

Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2024
@volcano-sh-bot volcano-sh-bot merged commit a76f101 into volcano-sh:master Mar 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants