-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix jobflow CRD metadata.annotations: Too long error #3347
fix jobflow CRD metadata.annotations: Too long error #3347
Conversation
60ba82f
to
00cbc33
Compare
I remember this is fixed in #3197 |
8a6f16f
to
4496141
Compare
4496141
to
be9dbb4
Compare
Signed-off-by: guoqinwill <guoqinwill@163.com>
Signed-off-by: wangyang <wangyang8126@gmail.com> Signed-off-by: guoqinwill <guoqinwill@163.com>
be9dbb4
to
f766e4c
Compare
That pr fixed vcjob, here we fixed the jobflow resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,just wondering what is the length limit
may be like this:#3107 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix jobflow CRD metadata.annotations: Too long error。
It is caused after #3295 ,this modification refers to #3197