Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: removed function variable type (COR-000) #515

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: removed function variable type (COR-000) #515

wants to merge 1 commit into from

Conversation

zhihil
Copy link
Contributor

@zhihil zhihil commented Apr 3, 2024

Fixes or implements COR-000

Brief description. What is this change?

Remove FunctionVariableType from libs

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

Checklist

  • Breaking changes have been communicated, including:
    • New required environment variables
    • Renaming of interfaces (API routes, request/response interface, etc)
  • New environment variables have been deployed
  • Appropriate tests have been written
    • Bug fixes are accompanied by an updated or new test
    • New features are accompanied by a new test

@zhihil zhihil self-assigned this Apr 3, 2024
@zhihil
Copy link
Contributor Author

zhihil commented Apr 3, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request Apr 3, 2024
@zhihil
fix: removed function variable type (COR-000) (#515)
c494fc8 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements COR-000**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->

Remove `FunctionVariableType` from `libs`
@bors-vf
Copy link

bors-vf bot commented Apr 3, 2024

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title fix: removed function variable type (COR-000) [Merged by Bors] - fix: removed function variable type (COR-000) Apr 3, 2024
@bors-vf bors-vf bot closed this Apr 3, 2024
@bors-vf bors-vf bot deleted the brennan/remove-function-variable-type/COR-000 branch April 3, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecathectZero DecathectZero DecathectZero approved these changes

Assignees

@zhihil zhihil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhihil @DecathectZero