[Merged by Bors] - feat: added types for compiled cms variables (CV3-942) #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhihil
force-pushed
the
brennan/add-default-value-to-initialization/CV3-942
branch
from
88cfeef to
8443cee
Compare
zhihil
added
ready for review
and removed
in progress
zhihil
force-pushed
the
brennan/add-default-value-to-initialization/CV3-942
branch
from
1aa83d8 to
1df171d
Compare
|
z4o4z
approved these changes
Feb 8, 2024
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements CV3-942** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion --> Adds serialized `.cmsVariables` mapping to the surveyor context type. This is necessary to provide strict typing to
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
bors-vf
bot
deleted the
brennan/add-default-value-to-initialization/CV3-942
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CV3-942
Brief description. What is this change?
Adds serialized
.cmsVariablesmapping to the surveyor context type. This is necessary to provide strict typing toImplementation details. How do you make this change?
Added
.cmsVariablesproperty to the surveyor context. Added additional typings for CMS variables to support this change.This change duplicates a similar change in
@voiceflow/dtos. The changes in@voiceflow/dtosshould be the canonical way of implementing the types, but the change was duplicated here to reduce the effort required to refactor thegeneral-runtime. In the future, thegeneral-runtimeshould be refactored to use@voiceflow/dtos.Setup information
N/A
Deployment Notes
N/A
Related PRs
Checklist