Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: added version tag to base-types so the value can be shared (PL-000) #388

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: added version tag to base-types so the value can be shared (PL-000) #388

wants to merge 1 commit into from

Conversation

zhihil
Copy link
Contributor

@zhihil zhihil commented Nov 9, 2022 •
edited
Loading

Fixes or implements PL-000

Brief description. What is this change?

Adds new VersionTag enum that will be shared with various services in the codebases, rather than each service defining its own instance of VersionTag

Implementation details. How do you make this change?

Added VersionTag enum

Setup information

None

Deployment Notes

None

Related PRs

None

Checklist

  • this is a breaking change and should publish a new major version
  • appropriate tests have been written
  • any new env vars have been added to the notion doc and infra has been notified

@zhihil zhihil self-assigned this Nov 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhihil
Copy link
Contributor Author

zhihil commented Nov 10, 2022

bors r+

bors-vf bot pushed a commit that referenced this pull request Nov 10, 2022
@zhihil
feat: added version tag to base-types so the value can be shared (PL-…
eaac4e8 
…000) (#388)

<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements PL-000**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->

Adds new `VersionTag` enum that will be shared with various services in the codebases, rather than each service defining its own instance of `VersionTag`
@bors-vf
Copy link

bors-vf bot commented Nov 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title feat: added version tag to base-types so the value can be shared (PL-000) [Merged by Bors] - feat: added version tag to base-types so the value can be shared (PL-000) Nov 10, 2022
@bors-vf bors-vf bot closed this Nov 10, 2022
@bors-vf bors-vf bot deleted the brennan/add-version-tag/PL-000 branch November 10, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecathectZero DecathectZero DecathectZero approved these changes

Assignees

@zhihil zhihil

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhihil @DecathectZero