Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type to debug (VF-1294) #33

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

DecathectZero
Copy link
Member

Fixes or implements VF-1294

Brief description. What is this change?

Also should make enum of all the debug types.
I think the only concern is if this is gonna look awkward or something:

{
    type: 'debug',
    payload: {
       type: 'some kinda debug type',
       message: 'stuff here'
    }
}

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

branch PR
other_pr_production link
other_pr_master link

Checklist

  • title of PR reflects the branch name
  • all commits adhere to conventional commits
  • appropriate tests have been written
  • all the dependencies are upgraded

@DecathectZero DecathectZero force-pushed the tyler/debug-type/VF-1294 branch from d264b6e to 11f4e86 Compare September 13, 2021 18:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DecathectZero DecathectZero merged commit c98af3a into master Sep 13, 2021
@DecathectZero DecathectZero deleted the tyler/debug-type/VF-1294 branch September 13, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants