[Merged by Bors] - feat(base-types): more tweaks to runtime logging (VF-3552) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahsnider
changed the title
jonahsnider
added
ready for review
and removed
in progress
jonahsnider
commented
Jun 8, 2022
| @@ -34,3 +37,42 @@ export enum StepLogKind { | |||
| export enum GlobalLogKind { | |||
| CONVERSATION_START = 'conversation_start', | |||
| } | |||
|
|
|||
| const NODE_TYPE_TO_STEP_LOG_KIND = { | |||
There was a problem hiding this comment.
this is an incomplete list and i would greatly appreciate help in expanding it by adding new items to StepLogKind and mapping them here. this is used to map our internal NodeType values to a human-friendly StepLogKind value. ex. IF and IF_V2 correspond to the CONDITION step
There was a problem hiding this comment.
Can always add to this as needed during log creation, too.
trs
approved these changes
Jun 8, 2022
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
**Fixes or implements VF-3552** ### Brief description. What is this change? more minor changes to runtime logging utils & types - add `LogLevel.OFF` - `export *` for utils (just remember not to export anything that should be private/internal) - narrowing types - add type guard for narrowing `string` to `LogLevel` - updating the messages for various logs - a `nodeTypeToStepLogKind()` method for converting `NodeType` to human-friendly `StepLogKind` values ### Checklist - [ ] this is a breaking change and should publish a new major version - [ ] appropriate tests have been written
jonahsnider
force-pushed
the
jonah/runtime-logging-helpers/VF-3552
branch
from
a46874d to
65e140d
Compare
|
Canceled. |
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
**Fixes or implements VF-3552** ### Brief description. What is this change? more minor changes to runtime logging utils & types - add `LogLevel.OFF` - `export *` for utils (just remember not to export anything that should be private/internal) - narrowing types - add type guard for narrowing `string` to `LogLevel` - updating the messages for various logs - a `nodeTypeToStepLogKind()` method for converting `NodeType` to human-friendly `StepLogKind` values ### Checklist - [ ] this is a breaking change and should publish a new major version - [ ] appropriate tests have been written
|
Kudos, SonarCloud Quality Gate passed!
|
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements VF-3552
Brief description. What is this change?
more minor changes to runtime logging utils & types
LogLevel.OFFexport *for utils (just remember not to export anything that should be private/internal)stringtoLogLevelnodeTypeToStepLogKind()method for convertingNodeTypeto human-friendlyStepLogKindvaluesChecklist