[Merged by Bors] - fix: make byKey port partial, to have better ts typecheck (VF-3527) #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4o4z
approved these changes
May 27, 2022
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
May 27, 2022
…290) <!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements VF-3527** ### Brief description. What is this change? Currently Ts is not complaining in the case `({} as Record<string, BasePort>).id.something` and ideally it should, since we will not be sure if the port is present for a given key or not.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements VF-3527
Brief description. What is this change?
Currently Ts is not complaining in the case
({} as Record<string, BasePort>).id.somethingand ideally it should, since we will not be sure if the port is present for a given key or not.