-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove database ID from public JSON URLs #316
Conversation
Having database IDs in some places, but not supporting them throughout the API is confusing. * add slug to related events metadata, remove id in a later commit * generated urls use guid for events * generated urls use acronym for conferences * recordings still use database ID
@rixx @MaZderMind regarding #314 I'd like to merge this, as it builds upon the previous approach to IDs in the public API. However changing the URLs will probably break the parsing done by @rixx? |
Well, I know about it now, but it may also break other projects who make the same assumptions. Otoh they'll notice and fix it. ;) Wouldn't it be better to replace the event_id in the related event section with the event_guid? Because you can use the guid to look up the event in the API, but you can't do that with the slug (or can you?) |
Ah, also, since you want to remove the IDs from your API entirely: The API provides the related events twice, once in the format you're fixing in this PR, and once in the
So you're still exposing IDs in that second place, as keys. |
Hey guys, I may be late to the party, but I haven't had any time the last couple of weeks. The changes here currently break the c3media library from @johnjohndoe and therefore also my TV App see issue. Until now I was also relying on the |
I don't plan on versioning the API.. that would mean we have to keep support for the old API and we barely have enough time for one... If I'd know who is using the API I could ping them in the future. Let's create a wiki page? |
@manno Are you aware of the list of projects? I would guess all the people behind would be interested to be informed up front about major changes. |
@johnjohndoe that list has quite a few github projects. However we only add non commercial front end projects. |
My thought was that each of such projects might already have or could add a project email address to their project site or repository README or somewhere in the source code. Then in the wiki each project could be listed with its name and a link to the location of the up-to-date email address. With this approach it is less likely that the email address becomes outdated. |
Having database IDs in some places, but not supporting them throughout
the API is confusing.