-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API change: related Events saved in Metadata changes from JSONArray to JSONObject #297
Comments
Can you provide before/after example snippets? |
@stefanmedack or just the API URL where this happens
gives a list of these:
That change was required i.e. to prune weak I'm sorry if that broke your application, but it is a required change. Can't you just call |
Okay, in this case that is unfortunate for us. But again: wouldn't it make sense to still use a list of objects. So I would suggest to change the structure to
|
I don't think it would make sense to change that for voctoweb internally? I would consider a PR which change this externally for API clients in the view at |
@manno Do I correctly understand that you would be fine with changing the public API for ...
{
"related": [
{
"event_id" : "2983",
"weight": 2
},
{
"event_id" : "3466",
"weight": 2
}
],
"remote_id": "7726"
} It would be great to get help with how to modify the builder with regards to the |
Idea for the future: We should thinking about solving such issues with a new GraphQL based API endpoint. |
✅ Fixed in the c3media-base client library here. /cc @stefanmedack |
This API change is not very recent, but I always forgot to add an issue for it. For some reason the field of related events saved in the Metadata of an Event has been changed from JSONArray to a JSONObject in the API. This leads to problems in parsing the Metadata for example in https://github.com/johnjohndoe/c3media-base by @johnjohndoe or in my project that uses this library https://github.com/stefanmedack/cccTV
Is it possible to revert this change at least for the API? I would also argue that it does not make sense to save a list of related events as a key/value pair, since it is a list and can now hardly be parsed or iterated (at least in Java/Kotlin, but most likely in other languages as well).
The text was updated successfully, but these errors were encountered: