This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Strict deployment loading from configmap #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployment from configmap and fail on unknown keys
|
@andresmgot is there a place in the docs where we can note this? |
andresmgot
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Thanks @andrascz! Yes, you can add a bit of documenation about this at https://github.com/kubeless/kubeless/blob/master/docs/function-controller-configuration.md#using-configmap
Once you add that I will merge this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: #1197
Description:
Fail if a deployment configuration in the ConfigMap has unknown or duplicate keys.
TODOs: