Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

consider resources for initContainers if provided in function deploym… #1074

Merged
merged 7 commits into from
Aug 20, 2019
Merged

consider resources for initContainers if provided in function deploym… #1074

merged 7 commits into from
Aug 20, 2019

Conversation

abinet
Copy link
Contributor

@abinet abinet commented Aug 15, 2019

Issue Ref: #960

Description:

This PR allows to provide default resources for initContainers if they need to be created.

@abinet
Copy link
Contributor Author

abinet commented Aug 16, 2019

I think there is a general problem with CI build right now.
go tools vet is deprecated and should be replaced by go vet. But go vet does not work properly with individual files (see https://circleci.com/gh/kubeless/kubeless/2633?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

From other POV vetting is already included into go test by default:

As part of building a test binary, go test runs go vet on the package
and its test source files to identify significant problems. If go vet
finds any problems, go test reports those and does not run the test
binary. Only a high-confidence subset of the default go vet checks are
used. That subset is: 'atomic', 'bool', 'buildtags', 'nilfunc', and
'printf'. You can see the documentation for these and other vet tests
via "go doc cmd/vet". To disable the running of go vet, use the
-vet=off flag.

So that's why I'm going to remove ./script/validate-vet from the validation step.

andresmgot
andresmgot approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! It's looking good so far :)

Regarding the issue with vet, I agree, I had to disable it for other projects as well so I am okay removing it.

I have a minor comment but apart from that, do you mind adding an example in the docs of how to use this? Maybe this section is the most appropriate for that: https://github.com/kubeless/kubeless/blob/master/docs/advanced-function-deployment.md#custom-deployment

pkg/utils/kubelessutil.go Outdated Show resolved Hide resolved
@andresmgot
Copy link
Contributor

Thank you for the changes!

@andresmgot andresmgot merged commit ba4c1a0 into vmware-archive:master Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abinet @andresmgot