Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Selenium-Grid into NSXT env #8425

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

luwang-vmware
Copy link
Contributor

@luwang-vmware luwang-vmware commented Dec 20, 2018

Use NSXT env for Selenium-Grid testing. Fix issue #7682 #8422

@luwang-vmware luwang-vmware requested a review from a team as a code owner December 20, 2018 03:04
@luwang-vmware luwang-vmware force-pushed the fix_issue branch 5 times, most recently from ef72ec9 to 19867d4 Compare December 21, 2018 04:53
@luwang-vmware luwang-vmware force-pushed the fix_issue branch 18 times, most recently from ce89e12 to 9d6fb31 Compare December 27, 2018 11:14
@luwang-vmware luwang-vmware force-pushed the fix_issue branch 3 times, most recently from 9d54436 to 8af427b Compare January 3, 2019 09:32
@luwang-vmware luwang-vmware force-pushed the fix_issue branch 6 times, most recently from 43563ed to 22a2242 Compare January 7, 2019 03:23
@luwang-vmware
Copy link
Contributor Author

@luwang-vmware luwang-vmware changed the title WIP: Integrate Selenium-Grid into NSXT env Integrate Selenium-Grid into NSXT env Jan 7, 2019
[Arguments] ${pod_name} ${testrunid}

#Reset NIMBUS_PERSONAL_USER value to the initial value
Remove Environment Variable NIMBUS_PERSONAL_USER
Set Environment Variable NIMBUS_PERSONAL_USER ${nimbus_personal_user_cache}

G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it

Copy link
Contributor

@yuyangbj yuyangbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one nit.

4. Destroy the created VIC appliance and VCH

# Case 2 Test Steps:
1. Create a new logical switches for bridge and container network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 new logical switches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will create 2 VCH and each one uses different LS as bridge network.


# Case 2 Test Steps:
1. Create a new logical switches for bridge and container network
2. Install VIC appliance and deploy 2 VCHs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are 2 VCHs required for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous Selenium grid issue is due to two Selenium hub are using the same IP address., which cause selenium node can not register with selenium hub.

With NSXT, using different LS, two VCH should be isolated with each other. So create 2 VCH to double confirm it.

[Arguments] ${pod_name} ${testrunid}

#Reset NIMBUS_PERSONAL_USER value to the initial value
Remove Environment Variable NIMBUS_PERSONAL_USER
Set Environment Variable NIMBUS_PERSONAL_USER ${nimbus_personal_user_cache}

G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does G mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it.

1. Create LS in the NSXT env
2. Create VCH to use that LS as bridge and container network
3. Create selenum-gride in the VCH
@luwang-vmware luwang-vmware merged commit 470d6a6 into vmware:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants