-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Selenium-Grid into NSXT env #8425
Conversation
ef72ec9
to
19867d4
Compare
ce89e12
to
9d6fb31
Compare
9d54436
to
8af427b
Compare
43563ed
to
22a2242
Compare
Scenario testing is PASSED https://vic-jenkins.eng.vmware.com/view/Scenario/job/vic-pr-test/2385/ |
[Arguments] ${pod_name} ${testrunid} | ||
|
||
#Reset NIMBUS_PERSONAL_USER value to the initial value | ||
Remove Environment Variable NIMBUS_PERSONAL_USER | ||
Set Environment Variable NIMBUS_PERSONAL_USER ${nimbus_personal_user_cache} | ||
|
||
G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides one nit.
4. Destroy the created VIC appliance and VCH | ||
|
||
# Case 2 Test Steps: | ||
1. Create a new logical switches for bridge and container network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 new logical switches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will create 2 VCH and each one uses different LS as bridge network.
|
||
# Case 2 Test Steps: | ||
1. Create a new logical switches for bridge and container network | ||
2. Install VIC appliance and deploy 2 VCHs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are 2 VCHs required for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous Selenium grid issue is due to two Selenium hub are using the same IP address., which cause selenium node can not register with selenium hub.
With NSXT, using different LS, two VCH should be isolated with each other. So create 2 VCH to double confirm it.
[Arguments] ${pod_name} ${testrunid} | ||
|
||
#Reset NIMBUS_PERSONAL_USER value to the initial value | ||
Remove Environment Variable NIMBUS_PERSONAL_USER | ||
Set Environment Variable NIMBUS_PERSONAL_USER ${nimbus_personal_user_cache} | ||
|
||
G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does G mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove it.
22a2242
to
cb7097c
Compare
1. Create LS in the NSXT env 2. Create VCH to use that LS as bridge and container network 3. Create selenum-gride in the VCH
cb7097c
to
04f1c93
Compare
Use NSXT env for Selenium-Grid testing. Fix issue #7682 #8422