control-service: add data job deployment dynamic property source selection mechanism #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
approved these changes
Sep 5, 2023
...cts/control-service/projects/helm_charts/pipelines-control-service/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
dakodakov
approved these changes
Sep 5, 2023
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
…l-service/values.yaml Co-authored-by: Andy <87700128+doks5@users.noreply.github.com>
…c/main/resources/application.properties Co-authored-by: Andy <87700128+doks5@users.noreply.github.com>
antoniivanov
force-pushed
the
person/mzhivkov/dynamic-property-featureflag
branch
from
287b7f6 to
581d850
Compare
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
Added a feature flag mechanism which will be used to allow for writes to both K8S and the database, and providing the flexibility to select the data source (either the database or K8S) when reading properties based on the feature flag configuration.
why:
This change anticipates future work on: https://github.com/vmware/versatile-data-kit/tree/main/specs/vep-2272-complete-data-job-configuration-persistence#database-data-model-changes. which aims to remove the dependency on the Kubernetes (K8S) cluster for storing part of the configuration of data jobs. By decoupling the configuration from the K8S cluster, we can improve the backup/restore process and overall system performance. Currently, the loss of K8S namespace results in the potential loss of data jobs, requiring a manual and complex restoration process.
testing:
added unit test which checks default configuration