vdk-jupyter: add deploy job component to the UI #1704
Conversation
There was a problem hiding this comment.
Could you add how is the change tested and verified?
On the question in PR description, how to implement enable/disable,
I think these boolean states (either one or another) are best visualised with an "enabled" checkbox (may default to true).
(nit: then, the value of the checkbox, could additionally be made in sync (fetched) with latest job state at one moment.)
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Outdated
Show resolved
Hide resolved
|
I like the idea about just having Enabled and f it is unchecked to interpret it as Disabled. |
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-ui-add-deploy-job-component
branch
from
20a580c to
f52b175
Compare
|
|
|
Please for name of buttons and other operations, look at what we have in the Operations UI and use the same namings. |
Okay, I will do it for deploy but for the other operations shouldn't it be a separate effort? |
There was a problem hiding this comment.
LVGTM, I like the generalised visual elements are reusable with broader context. For example,
.p-create-job-checkbox becomes .jp-vdk-checkbox since could be reused in every dialog, including but not limited to create.
I looked at the tests, all the tests cover the form fields mapping to the default values expected. In the future, when input validation will be planned, we may need to test the input is also set with the dialog-backing object.
.../vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Show resolved
Hide resolved
.../vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts
Outdated
Show resolved
Hide resolved
.../vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-ui-add-deploy-job-component
branch
from
08691c8 to
2ec345f
Compare
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
duyguHsnHsn
deleted the
person/hduygu/vdk-jupyter-ui-add-deploy-job-component
branch
What: Added the JSX component for deploy job. The component is for creating a deployment not fore removing/updating. Why: Linked to the issue #1282 Tests: jest unit tests Signed-off-by: Duygu Hasan [hduygu@vmware.com](mailto:hduygu@vmware.com) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What:
Added the JSX component for deploy job. The component is for creating a deployment not fore removing/updating.
This is how it looks:
Please address everything you think that must be change visually.
PS: Please, give ideas on how to introduce the "Disable", "Enable" flags. You can see them here: https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli.py
Why: Linked to the issue #1282
Tests: jest unit tests
Signed-off-by: Duygu Hasan hduygu@vmware.com