Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable TenantManager in vcsim #3477

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

fdawg4l
Copy link
Contributor

@fdawg4l fdawg4l commented Jun 27, 2024

Description

  • Tests were skipped to support older clients (<6.9). Since supported clients have support for TenantManager, unskipped the test and removed the OldClients test.

Type of change

Please mark options that are relevant:

  • [ *] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • [ x] Ran go test -v -test.name=TestTenant which passed.
  • [ x] Ran make test which failed on TestHostContainerBacking because I don't have docker installed(?).

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

dougm
dougm previously approved these changes Jun 27, 2024
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fdawg4l !

* Tests were skipped to support older clients (<6.9).  Since supported
  clients have support for TenantManager, unskipped the test and removed
  the OldClients test.
@fdawg4l fdawg4l merged commit 71f407c into vmware:main Jun 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants