nfc: Record the SSL thumbprint for the host the (device) URL refers to #3461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change we are recording the SSL thumbprint for the host the device URL refers to. This is done so that clients of the nfc wrapper can perform their own SSL verification using the recorded thumbprint if necessary. The thumbprint is stored in the FileItem struct, but the New constructor is not modified so as not to introduce any breaking changes.
Please note that the thumbprint is recorded only for the import case (when deploying an OVF in my case) since that is the only necessary path for our internal usage.
Closes:
NA
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
I have performed isolated testing against both a vCenter and a ESXi host. I have observed that the thumbprint is recorded and accessible through the
FileItem
struct as expected.Checklist:
CONTRIBUTION
guidelines of this project