Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govc: Add feature to pass fullname and org for windows vm customization #3444

Merged
merged 1 commit into from
Jun 7, 2024
Merged

govc: Add feature to pass fullname and org for windows vm customization #3444

merged 1 commit into from
Jun 7, 2024

Conversation

rubinthomasdev
Copy link
Contributor

@rubinthomasdev rubinthomasdev commented May 18, 2024 •
edited
Loading

Description

Added two new flags to pass the fullname and org for windows vm customization mandatory parameters.

Closes: #3443

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • run below command to test that the vm is getting customized successfully
govc vm.customize -vm=<windows-vm-name> -u="<vcenter-url>" -dc="<datacenter-name>" -ip=<vm-ip> -netmask=<netmask> -gateway=<gateway-ip> -name=<windows-vm-name> -type=Windows -domain="<domain-name>" -username="firsname lastname" -org="myorg"

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@rubinthomasdev, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@rubinthomasdev, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

dougm
dougm reviewed May 28, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rubinthomasdev , please run make doc and include the update to govc/USAGE.md
Then we can merge once the CLA is approved

dougm
dougm reviewed May 28, 2024
View reviewed changes
govc/vm/customize.go Outdated Show resolved Hide resolved
@rubinthomasdev
Copy link
Contributor Author

Thank you @dougm for the review. I have done the following changes based on the review :

  1. run make doc to update the govc doc
  2. removed the unnecessary check on empty strings and restructured the code based on the example above (thank you for the example).

dougm
dougm reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request on the doc. Could you also squash the commits and force push? We don't have the rebase option enabled for this repo, merge only. Thanks @rubinthomasdev

govc/vm/customize.go Outdated Show resolved Hide resolved
@rubinthomasdev
Copy link
Contributor Author

@dougm Thank you for the suggestion. This makes the document more user friendly with Windows only : tag added. I have added the update and squashed and force pushed the changes.

dougm
dougm approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rubinthomasdev !

@dougm dougm merged commit b9a71f7 into vmware:main Jun 7, 2024
10 checks passed
@vmwclabot
Copy link
Member

@rubinthomasdev, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Customize option failing for Windows VM due to missing Userdata
3 participants
@rubinthomasdev @vmwclabot @dougm