Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all required args to function #15

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

JDGrimes
Copy link
Contributor

@JDGrimes JDGrimes commented Jul 27, 2016

This is apparently is a result of JetBrains/intellij-community@0ec2768#diff-da751a166c55451a00fb447791ba3b9eL130. The problem is that the signature of that function was changed to expect a fourth parameter, which should be the Project object. Fortunately we have one handy in the project attribute.

Note that this is my first ever foray into Java from a PHP world, and that I haven't tested this fix yet.

Fixes #12, #13, #14


This change is Reviewable

This is apparently is a result of JetBrains/intellij-community@0ec2768#diff-da751a166c55451a00fb447791ba3b9eL130. The problem is that the signature of that function was changed to expect a fourth parameter, which should be the `Project` object. Fortunately we have one handy in the `project` attribute.

Note that this is my first ever foray into Java from a PHP world, and that I haven't tested this fix yet.

Fixes vkravets#12, vkravets#13, vkravets#14
@vkravets vkravets merged commit 3068610 into vkravets:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin doesn't work in WS-140.2424
2 participants