Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): timeout long sync hook #7289

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 19, 2025

Description

Reproduction

import { beforeAll, test } from 'vitest';

beforeAll(() => {
  const start = Date.now();
  while (Date.now() < start + 200) {}
}, 100);

test('ok', () => {});

#7281 is a great fix, but it was missing handling the same timeout for non promise result, which only happens on sync hooks since test functions are always wrapped with withAwaitAsyncAssertions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa marked this pull request as ready for review January 19, 2025 03:47
packages/runner/src/context.ts Outdated Show resolved Hide resolved
@sheremet-va sheremet-va merged commit c60ee27 into vitest-dev:main Jan 21, 2025
13 checks passed
@hi-ogawa hi-ogawa deleted the fix-sync-hook-timeout branch January 22, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants