Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed readHelloWorld in exampele 3 to return a string #7272

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

pjotrsavitski
Copy link
Contributor

Description

File system mocking example would not run as readHelloWorld returns a buffer with test assertions expecting a text instead. It seems that the returned value should be a string, which is a simpler solution that to call .toString() in the tests. The name of the variable also suggests that text is expected to be returned.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

It seems that tests are expecting a string with buffer being returned.
docs/guide/mocking.md Outdated Show resolved Hide resolved
@sheremet-va sheremet-va merged commit 74fe67c into vitest-dev:main Jan 16, 2025
1 check passed
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9369213
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67895b0dcb556600086f13f9
😎 Deploy Preview https://deploy-preview-7272--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 6640ed4
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67895ba38abfa300086be57a
😎 Deploy Preview https://deploy-preview-7272--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants