fix: prevent infinite loop on prettyDOM calls #7250

tsirlucas · 2025-01-14T18:53:30Z

Description

Fixed infinite loop described in ~~#7152~~ #7249

Thought about adding a test case but it would just enter the loop and timeout the pipeline instead of failing (this was happening to my setup in the private repo haha). WDYT?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2025-01-14T18:56:01Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`8f6f9a6`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/6787f1c8a115430008450b5d
😎 Deploy Preview	https://deploy-preview-7250--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tsirlucas · 2025-01-14T18:56:12Z

packages/utils/src/display.ts

-
+
+  // Prevents infinite loop https://github.com/vitest-dev/vitest/issues/7249
+  const nextMaxDepth = maxDepth === Infinity ? Number.MAX_VALUE : Math.floor(maxDepth / 2)


I think here instead of Number.MAX_VALUE we could go with result.length. The max possible depth in the DOM will never be bigger than the length of its stringified content. But Im afraid Im missing some edge case (e.g. custom maxLength may mess things up) so Number.MAX_VALUE is safer approach IMO.

This is stil a pretty big recursion so I wonder how it will behave in CI env with limited resources. Will run a test and get back here.

Ok I have pretty similar results time-wise doesnt matter if I use Number.MAX_VALUE or just 10.

hi-ogawa · 2025-01-15T05:08:52Z

I think we can avoid infinity for prettyDOM.

vitest/packages/browser/src/client/tester/public-utils.ts

Line 58 in f9a6284

const pretty = stringify(dom, Number.POSITIVE_INFINITY, {

I'd imagine practically it wouldn't matter whether the dom is truncated at 100, or even just 10. Pretty-format's maxDepth is quite scary and, for example, we reduced from 10 to 8 in other cases #7133

Can you add test cases with repro from #7249 (comment)?

tsirlucas · 2025-01-15T13:36:29Z

packages/browser/src/node/providers/playwright.ts

@@ -185,6 +185,12 @@ export class PlaywrightBrowserProvider implements BrowserProvider {
      })
    }

+    // unhandled page crashes will hang vitest process


this was making the tests hang #7249 (comment)

tsirlucas · 2025-01-15T13:37:28Z

packages/utils/src/display.ts

@@ -73,8 +73,10 @@ export function stringify(
    })
  }

+  // Prevents infinite loop https://github.com/vitest-dev/vitest/issues/7249
+  const nextMaxDepth = maxDepth === Infinity ? Number.MAX_SAFE_INTEGER : Math.floor(maxDepth / 2)


MAX_NUMBER would still crash the browser, so Im using MAX_SAFE_INTEGER which works fine. If you want me to use any specific number, please send it here so I can replace

tsirlucas · 2025-01-15T13:39:21Z

test/browser/test/browser-crash.test.ts

@@ -0,0 +1,15 @@
+import { it } from 'vitest';
+
+it.skip('fails gracefully when browser crashes', async () => {


I dont know what to do with this test. It reproduces the issue where browser crashes, but if I enable it it will break the pipeline

You can add this test to fixtures and create a new test file in test/browser/specs to run the fixture and assert that it fails correctly

tsirlucas · 2025-01-15T13:40:08Z

@hi-ogawa added a few changes & tests and left a few comments. would you mind taking a look again?

tsirlucas · 2025-01-15T18:09:39Z

ok i think im hitting a wall with the window tests... any idea what it may be?

tsirlucas · 2025-01-16T00:20:48Z

ok... the old 20k nodes test was messing up with perf/stability in CI.

i adjusted the test case to test a simpler scenario that would still break without the changes in PR

also adjusted how we simulate crashes for same reason as above.

tsirlucas · 2025-01-16T00:21:59Z

packages/utils/src/display.ts

  return result.length >= MAX_LENGTH && maxDepth > 1
-    ? stringify(object, Math.floor(maxDepth / 2))
+    ? stringify(object, nextMaxDepth, { maxLength, ...options })


i noticed that maxLength and options were not being sent to recursive child calls before so i added it here

hi-ogawa · 2025-01-16T02:01:05Z

packages/utils/src/display.ts

  return result.length >= MAX_LENGTH && maxDepth > 1
-    ? stringify(object, Math.floor(maxDepth / 2))
+    ? stringify(object, nextMaxDepth, { maxLength, ...options })


Maybe one liner?

Suggested change

? stringify(object, nextMaxDepth, { maxLength, ...options })

? stringify(object, Math.floor(Math.min(maxDepth, Number.MAX_SAFE_INTEGER) / 2), { maxLength, ...options })

sheremet-va

LGTM!

@Lordfirespeed

##### [v3.0.0](https://github.com/vitest-dev/vitest/releases/tag/v3.0.0) ##### 🚨 Breaking Changes - `spy.mockReset` changes - by [@Lordfirespeed](https://github.com/Lordfirespeed) in vitest-dev/vitest#6426 [<samp>(db7a8)</samp>](vitest-dev/vitest@db7a8888) - Pass down context to test hooks - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7034 [<samp>(82c2e)</samp>](vitest-dev/vitest@82c2e244) - Support Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7026 [<samp>(7abe8)</samp>](vitest-dev/vitest@7abe854c) - **coverage**: Always exclude test files - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7254 [<samp>(b5268)</samp>](vitest-dev/vitest@b5268965) - **deps**: Update fake-timers to v14.0.0 - by [@xxzefgh](https://github.com/xxzefgh) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7097 [<samp>(c98b4)</samp>](vitest-dev/vitest@c98b4b1c) - **expect**: Check more properties for error equality - by [@hi-ogawa](https://github.com/hi-ogawa) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#5876 [<samp>(10023)</samp>](vitest-dev/vitest@100230e9) - **runner**: Support `describe(..., { shuffle: boolean })` and inherit from parent suite - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6670 [<samp>(aa1da)</samp>](vitest-dev/vitest@aa1dac3d) - **snapshot**: Reset snapshot state for `retry` and `repeats` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6817 [<samp>(e8ce9)</samp>](vitest-dev/vitest@e8ce94cf) - **spy**: SpyOn reuses mock if method is already spyed on - by [@sheremet-va](https://github.com/sheremet-va) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6464 [<samp>(b3e43)</samp>](vitest-dev/vitest@b3e43d04) - **vitest**: Don't expose default toFake config - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6288 [<samp>(e3144)</samp>](vitest-dev/vitest@e3144fd8) ##### 🚀 Features - Support inline `diff` options and support `printBasicPrototype` - by [@hi-ogawa](https://github.com/hi-ogawa), [@sheremet-va](https://github.com/sheremet-va) and **Michał Grzegorzewski** in vitest-dev/vitest#6740 [<samp>(39186)</samp>](vitest-dev/vitest@391860f7) - Allow a custom note when calling `ctx.skip()` dynamically - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6805 [<samp>(697c3)</samp>](vitest-dev/vitest@697c35c5) - Allow inline workspace configuration - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6923 [<samp>(562e1)</samp>](vitest-dev/vitest@562e1b14) - Provide the current project to the global setup - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6942 [<samp>(a5bbc)</samp>](vitest-dev/vitest@a5bbc0a9) - Print project name as a label - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6925 [<samp>(a3bef)</samp>](vitest-dev/vitest@a3bef598) - Print a deprecation warning if suite or test uses object as the third argument - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7031 [<samp>(407f1)</samp>](vitest-dev/vitest@407f10e4) - Expose versions from `vitest/node` entry point and statically on Vitest - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7029 [<samp>(be8d4)</samp>](vitest-dev/vitest@be8d479b) - `diff.printBasicPrototype: false` by default - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7043 [<samp>(2b5c5)</samp>](vitest-dev/vitest@2b5c5201) - Prepare the Vitest API to be stable - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6962 [<samp>(9a1b5)</samp>](vitest-dev/vitest@9a1b5012) - Support Vite v6 in mocker package - by [@cexbrayat](https://github.com/cexbrayat) in vitest-dev/vitest#7058 [<samp>(96f47)</samp>](vitest-dev/vitest@96f47d37) - Allow multi-browser configuration - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6975 [<samp>(78b62)</samp>](vitest-dev/vitest@78b62ffe) - Add resolved project names to the reporter API - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#7213 [<samp>(91758)</samp>](vitest-dev/vitest@91758360) - Introduce the new reporter API - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7069 [<samp>(76662)</samp>](vitest-dev/vitest@766624ab) - Add `describe.for` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7253 [<samp>(0ad28)</samp>](vitest-dev/vitest@0ad2860b) - **api**: - Add onBrowserInit event - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7255 [<samp>(80ce0)</samp>](vitest-dev/vitest@80ce0e1c) - **browser**: - Support `actionTimeout` as playwright provider options - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6984 [<samp>(e2c29)</samp>](vitest-dev/vitest@e2c29eaf) - Support clipboard api `userEvent.copy, cut, paste` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6769 [<samp>(843a6)</samp>](vitest-dev/vitest@843a621e) - Implement locator.nth() - by [@xeger](https://github.com/xeger) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7137 [<samp>(38458)</samp>](vitest-dev/vitest@38458ea6) - **cli**: - Support excluding projects with `--project=!pattern` - by [@haines](https://github.com/haines) in vitest-dev/vitest#6924 [<samp>(ebfe9)</samp>](vitest-dev/vitest@ebfe942c) - Support specifying a line number when filtering tests - by [@mzhubail](https://github.com/mzhubail) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6411 [<samp>(4d94b)</samp>](vitest-dev/vitest@4d94b956) - Support location filters for suites - by [@mzhubail](https://github.com/mzhubail) in vitest-dev/vitest#7048 [<samp>(751e2)</samp>](vitest-dev/vitest@751e2dce) - **coverage**: - `thresholds` to support maximum uncovered items - by [@jonahkagan](https://github.com/jonahkagan) in vitest-dev/vitest#7061 [<samp>(bde98)</samp>](vitest-dev/vitest@bde98b6d) - **expect**: - Add `toHaveBeenCalledExactlyOnceWith` expect matcher - by [@jacoberdman2147](https://github.com/jacoberdman2147) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6894 [<samp>(ff662)</samp>](vitest-dev/vitest@ff66206a) - Add `toHaveBeenCalledAfter` and `toHaveBeenCalledBefore` utility - by [@Barbapapazes](https://github.com/Barbapapazes) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6056 [<samp>(85e6f)</samp>](vitest-dev/vitest@85e6f99f) - Add `toSatisfy` asymmetric matcher - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7022 [<samp>(f691a)</samp>](vitest-dev/vitest@f691ad76) - Add `toBeOneOf` matcher - by [@zirkelc](https://github.com/zirkelc) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6974 [<samp>(3d742)</samp>](vitest-dev/vitest@3d742b2b) - **reporter**: - Add support for function type to classname option in the junit reporter - by [@jpleclerc](https://github.com/jpleclerc), **Jean-Philippe Leclerc** and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6839 [<samp>(dc238)</samp>](vitest-dev/vitest@dc238e92) - **reporters**: - `summary` option for `verbose` and `default` reporters - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6893 [<samp>(511b7)</samp>](vitest-dev/vitest@511b73c7) - **runner**: - Test context can inject values from the config's `provide` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6813 [<samp>(85c64)</samp>](vitest-dev/vitest@85c64e35) - Add "queued" state - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6931 [<samp>(5f8d2)</samp>](vitest-dev/vitest@5f8d2091) - **snapshot**: - Provide `config` to `resolveSnapshotPath` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6800 [<samp>(746d8)</samp>](vitest-dev/vitest@746d8986) - **ui**: - Allow run individual tests/suites from the UI - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#6641 [<samp>(d9cc8)</samp>](vitest-dev/vitest@d9cc81dd) - Make clicking on a test in the UI open the report section and scroll to the test failure if applicable - by [@jacoberdman2147](https://github.com/jacoberdman2147) in vitest-dev/vitest#6900 [<samp>(1bf27)</samp>](vitest-dev/vitest@1bf27f0d) - Allow hide/show node_modules in module graph tab - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#7217 [<samp>(50cf6)</samp>](vitest-dev/vitest@50cf61b8) - **vitest**: - Include `coverageMap` in json report - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6606 [<samp>(9c8f7)</samp>](vitest-dev/vitest@9c8f7e3e) - Add `onTestsRerun` method to global setup context - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6803 [<samp>(e26e0)</samp>](vitest-dev/vitest@e26e066c) ##### 🐞 Bug Fixes - Misc fix for vite 6 ecosystem ci - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6867 [<samp>(80f8b)</samp>](vitest-dev/vitest@80f8bbf4) - Respect `cacheDir` when optimizer is enabled - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6910 [<samp>(0b08b)</samp>](vitest-dev/vitest@0b08bc11) - Reset runningPromise after `finally` in case there is an error to avoid it getting stuck - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6951 [<samp>(02194)</samp>](vitest-dev/vitest@021944cd) - Revert support for Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(fbe5c)</samp>](vitest-dev/vitest@fbe5c39d) - Support Node 21 - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(92f7a)</samp>](vitest-dev/vitest@92f7a2ad) - Don't use `Custom` internally - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(46fc5)</samp>](vitest-dev/vitest@46fc5340) - Don't use `Custom` internally" - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(db19f)</samp>](vitest-dev/vitest@db19f6eb) - Don't use `Custom` type internally - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7032 [<samp>(7957f)</samp>](vitest-dev/vitest@7957f912) - Persist cli filters as watch mode file filter - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6955 [<samp>(cc703)</samp>](vitest-dev/vitest@cc703362) - Don't use dim color for succeeded tests - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7059 [<samp>(8a6f5)</samp>](vitest-dev/vitest@8a6f5f16) - Fix missing chai types - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7149 [<samp>(6a09c)</samp>](vitest-dev/vitest@6a09cc3b) - `cancelCurrentRun` awaits `runningPromise` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7168 [<samp>(1dbf5)</samp>](vitest-dev/vitest@1dbf5140) - Add Locator typings for nth, first and last. - by [@xeger](https://github.com/xeger) in vitest-dev/vitest#7176 [<samp>(d262e)</samp>](vitest-dev/vitest@d262e059) - Batch console logs by microtask - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7183 [<samp>(53d1d)</samp>](vitest-dev/vitest@53d1d5f5) - Allow `getMockImplementation` to return "once" implementation - by [@chaptergy](https://github.com/chaptergy) in vitest-dev/vitest#7033 [<samp>(39125)</samp>](vitest-dev/vitest@3912554b) - `capturePrintError` logger duplicate event handlers - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7197 [<samp>(e89c3)</samp>](vitest-dev/vitest@e89c3693) - Allow slots in vitest-browser-vue - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7120 [<samp>(2319f)</samp>](vitest-dev/vitest@2319f849) - Reset root workspace project on restart - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7238 [<samp>(6e518)</samp>](vitest-dev/vitest@6e51843a) - Cleanup `vitest/reporters` entrypoint - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7241 [<samp>(aec0b)</samp>](vitest-dev/vitest@aec0b530) - Colors on `forks` pool - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7090 [<samp>(8cab9)</samp>](vitest-dev/vitest@8cab9601) - Export `VitestRunner` type from `vitest/runners` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7240 [<samp>(9b218)</samp>](vitest-dev/vitest@9b218854) - Return test fn result to runner - by [@wmertens](https://github.com/wmertens) in vitest-dev/vitest#7239 [<samp>(48645)</samp>](vitest-dev/vitest@48645bf4) - Re-apply default conditions if using vite 6 or later - by [@thebanjomatic](https://github.com/thebanjomatic), **thebanjomatic** and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7071 [<samp>(84287)</samp>](vitest-dev/vitest@84287fc2) - Prevent infinite loop on prettyDOM calls - by [@tsirlucas](https://github.com/tsirlucas) in vitest-dev/vitest#7250 [<samp>(a3a46)</samp>](vitest-dev/vitest@a3a46a53) - **api**: - Don't report events during `vitest list` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7257 [<samp>(1c2b2)</samp>](vitest-dev/vitest@1c2b210d) - **benchmark**: - Disable type testing while benchmarking - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7068 [<samp>(4e603)</samp>](vitest-dev/vitest@4e60333d) - Rewrite reporter without `log-update` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7019 [<samp>(6d23f)</samp>](vitest-dev/vitest@6d23f4b1) - **browser**: - Improve source maps when `vi.mock` is present - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6810 [<samp>(8d179)</samp>](vitest-dev/vitest@8d179afc) - Explain TypeScript support in docs and add asymmetric matchers to types - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6934 [<samp>(ac1a7)</samp>](vitest-dev/vitest@ac1a7fdc) - Fix matchers.d.ts - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6995 [<samp>(a485b)</samp>](vitest-dev/vitest@a485b32b) - Fix user event state on preview provider - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7041 [<samp>(8e944)</samp>](vitest-dev/vitest@8e94427e) - Fix provider options types - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7115 [<samp>(579bd)</samp>](vitest-dev/vitest@579bda97) - Only use locator.element on last expect.element attempt - by [@tsirlucas](https://github.com/tsirlucas) in vitest-dev/vitest#7139 and vitest-dev/vitest#7152 [<samp>(847d3)</samp>](vitest-dev/vitest@847d3221) - Use correct project when filtering `entries` in the browser mode - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7167 [<samp>(423d6)</samp>](vitest-dev/vitest@423d6345) - Fix `console.time` with fake timers - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7207 [<samp>(903f3)</samp>](vitest-dev/vitest@903f3b9b) - Add instance validation to resolve coverage error - by [@DevJoaoLopes](https://github.com/DevJoaoLopes) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7231 [<samp>(1e791)</samp>](vitest-dev/vitest@1e7915b5) - **coverage**: - Exclude browser mode iframe results - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6905 [<samp>(e04a1)</samp>](vitest-dev/vitest@e04a1368) - Correct coverage when `isolate: false` is used - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6957 [<samp>(426ce)</samp>](vitest-dev/vitest@426ce6d8) - Prevent crash when v8 incorrectly merges static_initializer's - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7150 [<samp>(cb6db)</samp>](vitest-dev/vitest@cb6db13e) - **deps**: - Update all non-major dependencies - in vitest-dev/vitest#7085 [<samp>(8cc92)</samp>](vitest-dev/vitest@8cc92c2f) - Update all non-major dependencies - in vitest-dev/vitest#7116 [<samp>(de5ce)</samp>](vitest-dev/vitest@de5ce3d9) - Update dependency pathe to v2 - in vitest-dev/vitest#7181 [<samp>(74dbe)</samp>](vitest-dev/vitest@74dbe03f) - **diff**: - Truncate to avoid crash on diff large objects - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7133 [<samp>(2a9d6)</samp>](vitest-dev/vitest@2a9d67a2) - **junit**: - Fix testsuites time to be sum of all testsuite items - by [@saitonakamura](https://github.com/saitonakamura) in vitest-dev/vitest#6985 [<samp>(ca37a)</samp>](vitest-dev/vitest@ca37a06a) - **pretty-format**: - Support react 19 - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6909 [<samp>(bd29b)</samp>](vitest-dev/vitest@bd29bcc7) - **reporters**: - Write buffered stdout/stderr on process exit - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6932 [<samp>(80cde)</samp>](vitest-dev/vitest@80cde2a0) - Rewrite `dot` reporter without `log-update` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6943 [<samp>(be969)</samp>](vitest-dev/vitest@be969cfb) - Check `--hideSkippedTests` in base reporter - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6988 [<samp>(721a5)</samp>](vitest-dev/vitest@721a5b84) - Show `retry` and `repeats` counts - by [@AriPerkkio](https://github.com/AriPerkkio) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7004 [<samp>(3496a)</samp>](vitest-dev/vitest@3496a015) - **runner**: - Long synchronous tasks does not time out - by [@ferdodo](https://github.com/ferdodo) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#2920 and vitest-dev/vitest#6944 [<samp>(2fb58)</samp>](vitest-dev/vitest@2fb585ae) - Mark tests of `describe.todo` as `'todo'` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7171 [<samp>(1d458)</samp>](vitest-dev/vitest@1d458955) - **snapshot**: - Fix "obsolete" message on snapshot update re-run - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7129 [<samp>(c2beb)</samp>](vitest-dev/vitest@c2beb8ca) - Preserve white space of `toMatchFileSnapshot` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7156 [<samp>(a437b)</samp>](vitest-dev/vitest@a437b656) - Fix obsoleteness check of `toMatchSnapshot("...")` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7126 [<samp>(ac9ba)</samp>](vitest-dev/vitest@ac9ba151) - **typecheck**: - Fix typecheck collect on Vite 6 - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6972 [<samp>(7b35d)</samp>](vitest-dev/vitest@7b35d13a) - Use unique temp and tsbuildinfo file for each tsconfig file - by [@masnormen](https://github.com/masnormen) in vitest-dev/vitest#7107 and vitest-dev/vitest#7112 [<samp>(61b30)</samp>](vitest-dev/vitest@61b30162) - Fix error test case mapping for `@ts-expect-error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7125 [<samp>(27d34)</samp>](vitest-dev/vitest@27d340aa) - **types**: - Make parameters non-nullable for Playwright options - by [@apple-yagi](https://github.com/apple-yagi) in vitest-dev/vitest#6989 [<samp>(fe2a1)</samp>](vitest-dev/vitest@fe2a187f) - **ui**: - Wrong module graph when generating html.meta.json.gz in browser mode - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#7214 [<samp>(dccdd)</samp>](vitest-dev/vitest@dccdd550) - Add errors and draft state (\*) to the code editor - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#7044 [<samp>(faca4)</samp>](vitest-dev/vitest@faca4de8) - **vite-node**: - Fix error stack on Windows - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6786 [<samp>(bf7b3)</samp>](vitest-dev/vitest@bf7b36ac) - Properly normalize file url import - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7087 [<samp>(31675)</samp>](vitest-dev/vitest@31675e3b) - Fix mandatory node prefix - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7179 [<samp>(b6284)</samp>](vitest-dev/vitest@b6284642) - **watch**: - Don't indicate exit when no matching files - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7246 [<samp>(003c0)</samp>](vitest-dev/vitest@003c0bef) - **workspace**: - `extends: true` correctly inherits all root config properties - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7232 [<samp>(798c0)</samp>](vitest-dev/vitest@798c0da2) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.8...v3.0.0)

fix: prevent infinite loop on prettyDOM calls

2605182

tsirlucas commented Jan 14, 2025

View reviewed changes

fix lint

f780722

tsirlucas added 3 commits January 15, 2025 10:34

use MAX_SAFE_INTEGER instead of MAX_VALUE

0b13cbf

add test case to handle large nested DOM in prettyDOM calls

6be46fe

handle browser crash in playwright provider

f815b0a

tsirlucas commented Jan 15, 2025

View reviewed changes

tsirlucas added 19 commits January 15, 2025 10:44

fix lint issues

9b02f20

bump test counter

ed16cda

Merge branch 'main' into main

0841caf

adjust test count

34ff688

Merge branch 'main' of https://github.com/tsirlucas/vitest

7c00ff2

rebump test count

c0b9c08

Merge branch 'main' into main

4e1adfc

fix browser crash test

e2f36ac

Merge branch 'main' of https://github.com/tsirlucas/vitest

3a343d3

force maxDepth to be under predefined value

8ee78bc

bump test counter

4d1728d

update snapshot

32a967f

update test counters

9c2f84d

add bigger timeout to large dom test

2189730

increase large dom test timeout

3bcb162

exit gracefully on webdriver crash

69299a2

Merge branch 'main' into main

8f6f9a6

fix lint

d88b2a1

Merge branch 'main' of https://github.com/tsirlucas/vitest

f10d107

tsirlucas added 9 commits January 15, 2025 19:54

better crashing strategy

fc4f64a

dont test crash on webkit

346c2ef

undo webdriver changes

39bc395

remove unneeded code

77b8972

better assertion for prettyDOM test

1a90e07

update maxContent for readability

0002e1b

adjust test so test counter is not dynamic

891036d

use different depth and maxContent values for better snapshots

ed80dc4

use test.runIf in browser crashing test

6307327

tsirlucas commented Jan 16, 2025

View reviewed changes

hi-ogawa reviewed Jan 16, 2025

View reviewed changes

pr review fix

90600e8

tsirlucas requested review from hi-ogawa and sheremet-va January 16, 2025 11:42

sheremet-va approved these changes Jan 16, 2025

View reviewed changes

sheremet-va merged commit a3a46a5 into vitest-dev:main Jan 16, 2025
13 checks passed

tsirlucas mentioned this pull request Jan 17, 2025

Infinite loop in prettyDOM calls crashes test when locator.element() is not found #7249

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: prevent infinite loop on prettyDOM calls #7250

fix: prevent infinite loop on prettyDOM calls #7250

tsirlucas commented Jan 14, 2025 •

edited by hi-ogawa

Loading

netlify bot commented Jan 14, 2025 •

edited

Loading

tsirlucas Jan 14, 2025

tsirlucas Jan 14, 2025

tsirlucas Jan 14, 2025

hi-ogawa commented Jan 15, 2025 •

edited

Loading

tsirlucas Jan 15, 2025

tsirlucas Jan 15, 2025

tsirlucas Jan 15, 2025

sheremet-va Jan 15, 2025

tsirlucas commented Jan 15, 2025

tsirlucas commented Jan 15, 2025

tsirlucas commented Jan 16, 2025

tsirlucas Jan 16, 2025

hi-ogawa Jan 16, 2025

sheremet-va left a comment



		// Prevents infinite loop https://github.com/vitest-dev/vitest/issues/7249
		const nextMaxDepth = maxDepth === Infinity ? Number.MAX_VALUE : Math.floor(maxDepth / 2)

		@@ -0,0 +1,15 @@
		import { it } from 'vitest';

		it.skip('fails gracefully when browser crashes', async () => {

	? stringify(object, nextMaxDepth, { maxLength, ...options })
	? stringify(object, Math.floor(Math.min(maxDepth, Number.MAX_SAFE_INTEGER) / 2), { maxLength, ...options })

fix: prevent infinite loop on prettyDOM calls #7250

fix: prevent infinite loop on prettyDOM calls #7250

Conversation

tsirlucas commented Jan 14, 2025 • edited by hi-ogawa Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

netlify bot commented Jan 14, 2025 • edited Loading

✅ Deploy Preview for vitest-dev ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hi-ogawa commented Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsirlucas commented Jan 15, 2025

tsirlucas commented Jan 15, 2025

tsirlucas commented Jan 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sheremet-va left a comment

Choose a reason for hiding this comment

tsirlucas commented Jan 14, 2025 •

edited by hi-ogawa

Loading

netlify bot commented Jan 14, 2025 •

edited

Loading

hi-ogawa commented Jan 15, 2025 •

edited

Loading