Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: split browser page #5988

Merged
merged 10 commits into from
Jul 1, 2024
Merged

docs: split browser page #5988

merged 10 commits into from
Jul 1, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Jun 27, 2024 •
edited
Loading

Description

PR in draft, we need:

We should review ignore command in netlify.toml, it seems it is breaking the PWA.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin marked this pull request as ready for review June 28, 2024 09:28
@userquin userquin requested a review from sheremet-va June 28, 2024 10:55
sheremet-va
sheremet-va previously approved these changes Jun 30, 2024
View reviewed changes
@sheremet-va
Copy link
Member

Hm, actually. There are a few spots missing:

vitest/packages/browser/context.d.ts

Line 221 in dafb2fc

* @see {@link https://vitest.dev/guide/browser#commands}

vitest/packages/browser/context.d.ts

Line 236 in dafb2fc

* @see {@link https://vitest.dev/guide/browser#commands}

vitest/packages/vitest/src/types/browser.ts

Line 158 in dafb2fc

* @see {@link https://vitest.dev/guide/browser#commands}

@userquin
Copy link
Member Author

Uhmm, browser.md changed, we need to include changes in your pr about screenshots https://github.com/vitest-dev/vitest/pull/5993/files#diff-4475ee69df684ca5a1001467dc52db44f175fc344270e85a7b6c78a3e2090026

@userquin userquin requested a review from sheremet-va July 1, 2024 09:14
@sheremet-va sheremet-va merged commit 50130bd into main Jul 1, 2024
15 of 16 checks passed
@sheremet-va sheremet-va deleted the userquin/docs-split-browser-page branch July 1, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@userquin @sheremet-va