Docs: Backup/BackupShard --incremental-from-pos accepts backup name #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
ajm188
approved these changes
Jan 24, 2024
mattlord
reviewed
Jan 24, 2024
Comment on lines
+55
to
+58
| --mysql_server_version string Configure the MySQL version to use for example for the parser. (default "8.0.30-Vitess") | ||
| --source-keyspace string Keyspace where the tables queried in the 'source_expression' values within table-settings live. | ||
| --sql-max-length-errors int truncate queries in error logs to the given length (default unlimited) | ||
| --sql-max-length-ui int truncate queries in debug UIs to the given length (default 512) (default 512) |
There was a problem hiding this comment.
Hmmm, this doesn't seem right.... I will see where this came from.
There was a problem hiding this comment.
Ah, I think it was parser related refactors that led to us getting these flags because we parse the query provided in the materialize statement. So this is fine.
mattlord
approved these changes
Jan 24, 2024
|
To be merged only once vitessio/vitess#14923 is merged. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the changes in vitessio/vitess#14923,
--incremental-from-posaccepting a backup name.There is a lot of noise because of SHA signatures. The relevant changes are mostly in
content/en/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup.mdand otherwise invtctlandvtctldclientdocs.Replaces #1662 which was a mess.