-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zustand store initialization and add hook for initial coordination values #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialCoordination hook
Size Change: +1.04 kB (0%) Total Size: 11.4 MB
ℹ️ View Unchanged
|
Coverage Report
File Coverage
|
* Add test for animated config * TODO comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1486
Fixes #1577
Related to #1571
TODO
uid
is always needed (since when paired withonConfigChange
in controlled component situation, it breaks the ability to leverage theconfig
object reference)vitessce/packages/vit-s/src/view-config-utils.js
Line 201 in 60084cd
onConfigChange
event, then would bypass validation (for performance). otherwise (e.g., if theconfig
traitlet is updated from the python side), then re-validate.config
object reference through all transformations (upgrade functions and zustand "reducer"s - and traitlet updates on python side)Change List
useInitialCoordination
hook to get the values of the coordination space from the initial config, which can be used for viewState reset buttons.config
object reference as hook dependency when noconfig.uid
is present (to support both controlled and un-controlled component cases).createViewConfigStore
function, rather than viauseEffect
.Checklist
vitessce-python
andvitessce-r
if this is a release PR