fix: ensure source maps can be traced by debugger #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Populate the `sourcesContent` array - Resolve relative paths in the `sources` array The `sourcesContent` of a source map can be null, which makes the devtools ask Vite for the original source. This can lead to Vite responding with transformed code, since Vite supports importing TypeScript directly. By populating the `sourcesContent` before sending the source map, the devtools won't need to ask Vite for the original source directly. The `sources` array may contain relative paths, which are resolved to a /@modules/ path by the devtools. It would be better to know the actual path of the original source, so this PR resolves the relative path before sending the source map to the debugger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcesContentarraysourcesarrayThe
sourcesContentof a source map can be null, which makes the devtools ask Vite for the original source. This can lead to Vite responding with transformed code, since Vite supports importing TypeScript directly. By populating thesourcesContentbefore sending the source map, the devtools won't need to ask Vite for the original source directly.The
sourcesarray may contain relative paths, which are resolved to a /@modules/ path by the devtools. It would be better to know the actual path of the original source, so this PR resolves the relative path before sending the source map to the debugger.