Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove node addon dir #6107

Merged
merged 1 commit into from
Dec 16, 2021
Merged

chore: remove node addon dir #6107

merged 1 commit into from
Dec 16, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Dec 14, 2021 •
edited
Loading

Description

Removing node addon directory that was added in 2d9a684

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9c8fb04 into vitejs:main Dec 16, 2021
@patak-dev
Copy link
Member

This was auto-commited when doing the release, there seems to be something wrong with the script here then

@ydcjeff ydcjeff deleted the chore/rm-node-addon branch December 17, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydcjeff @patak-dev @Shinigami92