Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve gitlab pages deployment #4534

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

Shinigami92
Copy link
Member

Description

Improve GitLab Pages deployment

Additional context

The cp -a dist/. public/ copies all stuff from build out dir to the GitLab required public folder.
That way on normal build locally you can still gitignore dist folder and no content was emitted/build to public folder.

I also updated some stuff like default branch and node image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Aug 7, 2021
@Shinigami92 Shinigami92 self-assigned this Aug 7, 2021
@antfu antfu merged commit 7232677 into main Aug 9, 2021
@Shinigami92 Shinigami92 deleted the improve-gitlab-pages-deployment-docs branch August 9, 2021 06:34
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants