Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: track deps for css @import in build watch mode(fix #3387) #3478

Merged
merged 3 commits into from
May 24, 2021
Merged

fix: track deps for css @import in build watch mode(fix #3387) #3478

merged 3 commits into from
May 24, 2021

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented May 20, 2021 •
edited
Loading

Description

Fix #3387

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 20, 2021
Shinigami92
Shinigami92 previously approved these changes May 20, 2021
View reviewed changes
@Shinigami92 Shinigami92 requested a review from patak-dev May 20, 2021 08:30
patak-dev
patak-dev requested changes May 23, 2021
View reviewed changes
packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev requested a review from Shinigami92 May 24, 2021 08:19
@patak-dev patak-dev merged commit 13bda33 into vitejs:main May 24, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
@CHOYSEN @ygj6
fix: track deps for css @import in build watch mode, fix vitejs#3387 (v…
09202c4 
…itejs#3478)
@CHOYSEN CHOYSEN deleted the fix_cssimport_watch branch June 10, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In watch mode, changes in @import'ed files don't trigger CSS rebuild
3 participants
@CHOYSEN @patak-dev @Shinigami92