fix: ignore ids that start with \0 in plugin asset, fix #3424 #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
approved these changes
May 16, 2021
antfu
approved these changes
May 17, 2021
The PR doesn't add more info than the comment. I'll think if there is a good test to be added that doesn't imply importing the quill library. Ideas welcomed if someone wants to tackle this. |
fi3ework
pushed a commit
to fi3ework/vite
that referenced
this pull request
May 22, 2021
soc221b
pushed a commit
to runtime-env/import-meta-env
that referenced
this pull request
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a convention in rollup that some plugins will mark an id with a
'\0'prefix. These ids should be then handled by the same plugin. In the case of #3424, an id of the form'\0/root/node_modules/quill/assets/icons/align-left.svg'was processed by Vite's asset plugin resulting in an error when trying to load the file. This same file was also present without the initial'\0'and loaded correctly. I don't fully understand why the extra prefixed id is being generated (probably by the commonjs plugin) but these ids should be handled by the plugin that generated them and AFAIU ignored by our internal plugins.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).