fix(static): serve .js, .jsx, .ts, .tsx as application/javascript #2769
Conversation
| import sirv from 'sirv' | ||
| import { Connect } from 'types/connect' | ||
| import { ResolvedConfig } from '../..' | ||
| import { FS_PREFIX } from '../../constants' | ||
| import { cleanUrl, isImportRequest } from '../../utils' | ||
|
|
||
| const sirvOptions = { dev: true, etag: true, extensions: [] } | ||
| const sirvOptions = { |
There was a problem hiding this comment.
You can import type { Options } from 'sirv'; and then
| const sirvOptions = { | |
| const sirvOptions: Options = { |
This means you don't have to import ServerResponse or type the setHeaders method.
There was a problem hiding this comment.
Thanks for the suggestion! I updated this PR now.
This fixes vitejs#2642. Thanks a lot to @lukeed, maintainer of Sirv, for the suggestion! lukeed/sirv#103 (comment)
eirslett
force-pushed
the
typescript-mime-type
branch
from
3edbd8f to
9858e03
Compare
patak-dev
added
the
p2-nice-to-have
|
Hey @eirslett, thanks for the PR! To test this, you can use Then you can link the project you want to debug with this local copy using |
| // for the MIME type video/mp2t. In almost all cases, we can expect | ||
| // these files to be TypeScript files, and for Vite to serve them with | ||
| // this Content-Type. | ||
| if (/\.[tj]sx?$/.test(pathname)) { |
There was a problem hiding this comment.
thought/question: Could cjs and mjs also be valid considerations? 🤔
| ext | kind | mime |
|---|---|---|
| mjs | JavaScript module | text/javascript |
| cjs | unknown | unknown |
There was a problem hiding this comment.
Possibly, I'm not sure what the maintainers would want it to be like... maybe it's better to do in a separate PR, at least now it's easy to find where you should add it in the code!
|
@patak-js thanks a lot for the help! I was able to test it locally now, and it works like intended! |
There was a problem hiding this comment.
I also tested it and it works great. Thanks a lot for the PR 💯
We may need to review as suggested if we should include other extensions in future PRs
We have an active #contributing channel in Vite Land, in case you would like to join. The debugging links were part of a discussion we had the day before there 😃
This fixes #2642. (Well, I believe it fixes it)
Thanks a lot to @lukeed, maintainer of Sirv, for the suggestion!
lukeed/sirv#103 (comment)
To be honest, I had a hard time finding a good way to test this fix - npm link didn't work for me, and I couldn't find any integration tests or documentation on how to develop locally using a forked version of Vite. Could somebody please point me in the right direction?