docs: note about a silly edge case in the ssr guide #18628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Nov 11, 2024
Oh yeah, makes sense, I'd prefer to get rid of the comment since I struggled with keeping it a single-liner when i originally posted that PR, people who concerned why there's a function are free to consult to MDN |
bluwy
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a mere heads up so people blindly copy-pasting the code from guide won't run in obscure hydration errors
The thing is String.prototype.replace function has a silly edge case where it can literally swallow a dollar and the remedy is just specifying a replacer function so it would ignore dollars and be less greedy
Note to reviewers: Please take the comment change with extra care bc i'm not rly sure i worded it properly