Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use originalFileNames/names #18240

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

sapphi-red
Copy link
Member

Description

Use originalFileNames and names which will be added by rollup/rollup#5686.

Copy link

stackblitz bot commented Sep 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 30, 2024
@sapphi-red
Copy link
Member Author

I didn't expect the tests to pass. I thought it will fail with rollup's rust part compilation but it seems it works without setup-rust-toolchain action. 😮

@sapphi-red sapphi-red marked this pull request as ready for review October 2, 2024 03:32
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

patak-dev
patak-dev previously approved these changes Oct 7, 2024
@patak-dev patak-dev added this to the 6.0 milestone Oct 14, 2024
bluwy
bluwy previously approved these changes Oct 24, 2024
@sapphi-red sapphi-red dismissed stale reviews from bluwy and patak-dev via 65d6fb1 October 24, 2024 09:11
@patak-dev patak-dev merged commit f2957c8 into vitejs:main Oct 24, 2024
14 checks passed
@sapphi-red sapphi-red deleted the refactor/use-original-file-names branch October 24, 2024 10:53
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 6, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 13, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 14, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 14, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 22, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 22, 2024
sapphi-red added a commit to rolldown/vite that referenced this pull request Nov 29, 2024
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Dec 4, 2024
<!-- Thank you for contributing! -->

### Description

close #2496

refs #2046,
rollup/rollup#5686,
vitejs/vite#18240

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
sapphi-red added a commit to rolldown/vite that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants