Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix load error handling window reload example #16159

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(docs): fix load error handling window reload example #16159

merged 1 commit into from
Mar 14, 2024

Conversation

seanwash
Copy link
Contributor

@seanwash seanwash commented Mar 14, 2024

Description

This pr makes a correction to the Load Error Handling example in the Building for Production documentation.

The snippet provides an example for reloading the page, but uses window.reload. reload is not a method defined on Window, it's defined on the Location object. See https://developer.mozilla.org/en-US/docs/Web/API/Location/reload


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

`reload` is not a method defined on `Window`, it's defined on the `Location` object.

See https://developer.mozilla.org/en-US/docs/Web/API/Location/reload
Copy link

stackblitz bot commented Mar 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 5aabad3 into vitejs:main Mar 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants