Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce test flakiness #14684

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

sapphi-red
Copy link
Member

Description

Each commit has a description.

related test fails

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

.demo is inject on browser side so this needs a retry
should wait for hmr connection message,
otherwise that log will be used in the next `untilBrowserLogAfter`
if a file is changed before hmr connection, I guess the full-reload won't happen
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Oct 18, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

unpkg sometimes takes time to load the file and that causes timeouts
if a file is changed before hmr connection, I guess the hmr won't happen
@sapphi-red sapphi-red force-pushed the chore/reduce-flakiness branch from ef818c7 to ecf7a7d Compare October 18, 2023 14:44
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sapphi-red sapphi-red merged commit 6ebac4c into vitejs:main Oct 19, 2023
9 checks passed
@sapphi-red sapphi-red deleted the chore/reduce-flakiness branch October 19, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants