fix(hmr): clean importers in module graph when file is deleted #14315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArnaudBarre
force-pushed
the
arnaud/fix-hmr-file-delete
branch
2 times, most recently
from
69c6f2e to
fa8ed2a
Compare
sun0day
reviewed
Sep 7, 2023
| 'count is 2!', | ||
| ) | ||
|
|
||
| // remove unused file, page reload because it's considered entry point now |
There was a problem hiding this comment.
would it be possible to avoid page reload or hmr when removing re-export.js, ideally re-export.js should be removed from moduleGraph when replacing from './re-export.js' with from './display.js'
There was a problem hiding this comment.
After investigation it seems unsafe to remove the entry when it has no importer left without knowing if the node was present before because it's referenced from the update module or maybe also from an html file.
ArnaudBarre
force-pushed
the
arnaud/fix-hmr-file-delete
branch
from
fa8ed2a to
3b0bcdd
Compare
bluwy
reviewed
Oct 17, 2023
ArnaudBarre
force-pushed
the
arnaud/fix-hmr-file-delete
branch
from
3b0bcdd to
40a4382
Compare
bluwy
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, any update to
display.jsafterre-export.jswas deleted triggered a full page reload.Actually because we don't (or maybe we have?) an exhaustive list of modules considered as entrypoints, the current heuristic of
no impoters->entrypointmake the hmr 'buggy' (ie unneeded page reload) in other situations: