Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mime missing extensions #8568

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

sapphi-red
Copy link
Member

Description

This PR fixes #8565 (comment)

  1. adds mime data for extensions which fails to lookup mime data
  2. fallbacks mime to application/octet-stream when mime data was not found

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 13, 2022
@sapphi-red sapphi-red marked this pull request as ready for review June 13, 2022 13:25
@patak-dev patak-dev merged commit acf3024 into vitejs:main Jun 13, 2022
@sapphi-red sapphi-red deleted the fix/mime-missing-extensions branch June 13, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants