Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce the usage of require #8121

Merged
merged 5 commits into from
May 12, 2022
Merged

chore: reduce the usage of require #8121

merged 5 commits into from
May 12, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented May 11, 2022

a small step to ESM

@antfu antfu changed the title chore: reduce the usage for require chore: reduce the usage of require May 11, 2022
@antfu antfu merged commit 67ff257 into main May 12, 2022
@antfu antfu deleted the chore/less-require branch May 12, 2022 03:55
if (proxy) {
// #484 fallback to http1 when proxy is needed.
return require('https').createServer(httpsOptions, app)
const { createServer } = await import('http')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natrim good catch! Would you like to send a PR to fix this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, #8143

@natrim natrim mentioned this pull request May 12, 2022
9 tasks
patak-dev pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants