Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vite connected logs changed to console.debug #7733

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

WORMSS
Copy link
Contributor

@WORMSS WORMSS commented Apr 14, 2022

Description

Changed log to debug to reduce spamming console

Changing this to debug from log means people can choose to show/not show this information with using Verbose on/off in devtools.
Otherwise it becomes super spammy while developing and adds nothing to the average vue developer experience

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Changing this to debug from log means people can choose to show/not show this information with using Verbose on/off in devtools.
Otherwise it becomes super spammy while developing and adds nothing to the average vue developer experience
@patak-dev
Copy link
Member

It isn't clear to me what is the best DX here. I know that @Akryum ended up hacking the Vite log messages to remove the same one in Histoire for example, so you aren't the only one that would appreciate moving them to Verbose. I'll add this PR to be discussed in a team meeting. If we do it, we should do it in Vite v3 so users aren't surprised by the messages no longer being there.

@patak-dev patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label Apr 27, 2022
@patak-dev patak-dev changed the title Changed log to debug to reduce spamming console feat: vite connected logs changed to console.debug Apr 27, 2022
@WORMSS
Copy link
Contributor Author

WORMSS commented Apr 27, 2022

okay, I am sure its useful if you are developing Vite.. Just adds nothing if you are writing a Vue app

@patak-dev
Copy link
Member

FWIW, we did a poll in Twitter: https://twitter.com/patak_dev/status/1519587004492754944?s=20&t=xxBP_-oeA0GuvZFLou_s6g, with 318 votes, 66% voted in favor of this PR

image

@patak-dev patak-dev added this to the 3.0 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-to-be-discussed Enhancement under consideration (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants