workflow: separate version bumping and publishing on release #6879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
commented
Feb 12, 2022
| run: pnpm install | ||
|
|
||
| - name: Publish package | ||
| run: pnpm run ci-publish -- ${{ github.ref_name }} --dry |
There was a problem hiding this comment.
TODO: remove the --dry flag
patak-dev
reviewed
Feb 12, 2022
|
The flow looks awesome Anthony, after seeing the three clicks (because of the environment approval) and waiting at each step for the GitHub UI to respond when using dispatch, it makes a lot more sense to use the CLI as you proposed. |
Kapture.2022-02-12.at.18.39.48.mp4Added a little helper to show the git diff since the last release |
patak-dev
reviewed
Feb 12, 2022
Co-authored-by: patak <matias.capeletto@gmail.com>
patak-dev
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow Changes
npm run releasescript moved to top-level with an interactive prompt to select the packagenpm run releaseinstead of GH action dispatchingnpm run releaselocally at project root of the latestmainbranchChanges Details
npm run releasemoved to root, and no longer runs building and publishing.--skipBuildoption has been removed. We useprepublishOnlyhook to trigger the build before publishing.changelogscripts in each package has been inlined in the release script to reduce duplicationnpm publishinstead ofyarn publishsince we already handle the version bumping.New Features
npm run releasewill show commits between the last release of a package for the maintainer to reference