fix(sourcemap): tolerate virtual modules in sources array
#5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this manually in a fresh React Vite app |
patak-dev
reviewed
Nov 8, 2021
| // false positive "missing source" warning. We also check for colons, | ||
| // because the optimizer emits sourcemaps with sources like "dep:react" | ||
| // due to namespacing for special handling in esbuildDepPlugin. | ||
| const virtualSourceRE = /:|\0/ |
There was a problem hiding this comment.
I would prefer this check to be more targeted. What about
Suggested change
| const virtualSourceRE = /:|\0/ | |
| const virtualSourceRE = /^(\0|dep:)/ |
This was referenced Nov 8, 2021
patak-dev
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we'll want to use Vite's module graph to actually include the content of virtual modules in the
sourcesContentarray. I'm already doing this in my Vite fork, and it works well.Closes #5438