Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error message for parse failures #5192

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Oct 4, 2021

Description

Add enough details to allow diagnosing parse failures. Right now, the error message is just Unexpected token (6:132), but there's no clue as to what file or code that occurs in, so is impossible to debug

Additional context

I've had a long-running project to covert svelte.dev over to SvelteKit. This is one of the current blocking issues. Improving this error message helped us track the down the root cause as another Vite bug: #3304


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Oct 4, 2021
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants