Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose preview method #5014

Merged
merged 4 commits into from
Sep 24, 2021
Merged

feat: expose preview method #5014

merged 4 commits into from
Sep 24, 2021

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Sep 21, 2021 •
edited
Loading

Description

Expose the preview method

Additional context

SvelteKit has its own preview functionality. It'd save us hundreds of lines of code if we could use Vite's instead of creating our own

It would probably be good to merge #5016 first since it changes the return type of preview

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

I'll bring this feat for discussion this Friday. I also think that is a good idea if we can collaborate on a single implementation of preview.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 21, 2021
@Shinigami92
Copy link
Member

I would like to have every exposed API to be documented 🤔
Seems we are exposing this and that here and there, we should start also documenting that stuff instead of just exposing it and no one knows what and why it was exposed...

@patak-dev
Copy link
Member

I think in this case it is a good idea to wait until we discuss if this feature gets consensus to be merged. But yes, we should document it before merging.

@benmccann benmccann mentioned this pull request Sep 22, 2021
Merged
5 tasks
Shinigami92
Shinigami92 previously approved these changes Sep 23, 2021
View reviewed changes
patak-dev
patak-dev approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this with the team today, let's merge this one. I think it is a good idea to leave it as @experimental for a bit. We can document it in the docs once we want to make it more public.

@patak-dev patak-dev merged commit 9885656 into vitejs:main Sep 24, 2021
@bluwy bluwy mentioned this pull request Sep 26, 2021
Closed
@patak-dev patak-dev mentioned this pull request Oct 24, 2021
Merged
4 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@benmccann @aleclarson
feat: expose preview method (vitejs#5014)
07053af
@bluwy bluwy mentioned this pull request Apr 8, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @patak-dev @Shinigami92