Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ?inline css query typings #4570

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix: add ?inline css query typings #4570

merged 1 commit into from
Aug 11, 2021

Conversation

crimx
Copy link
Contributor

@crimx crimx commented Aug 11, 2021

Description

Add the missing ?inline css query typings to vite/client.d.ts.

Additional context

Relate to this commit.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

As this works also with the .module.css form, maybe we should follow the same pattern as ?raw, ?url, etc and add it at the end as a generic *?inline match?

antfu
antfu previously approved these changes Aug 11, 2021
@crimx
Copy link
Contributor Author

crimx commented Aug 11, 2021

Done. Sorry didn't know it works with css module too.

@antfu antfu merged commit c8a17a2 into vitejs:main Aug 11, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants