fix: preserve base in HMR for CSS referenced in link tags #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, is it difficult to include a test for this in the backend-integration playground? |
|
@patak-js Adding an HMR test case is not difficult, but it wouldn't fail if the base is removed—Vite will serve files anyway. Not sure if there's a way to spy on the incoming requests to verify the prefix, couldn't find a similar test. |
patak-dev
previously approved these changes
Jul 27, 2021
|
Added a spec where we check the replaced |
patak-dev
previously approved these changes
Jul 27, 2021
Shinigami92
reviewed
Jul 27, 2021
packages/vite/src/client/client.ts
Outdated
Comment on lines
88
to
89
| base + | ||
| `${path.slice(1)}${path.includes('?') ? '&' : '?'}t=${timestamp}` |
There was a problem hiding this comment.
Suggested change
| base + | |
| `${path.slice(1)}${path.includes('?') ? '&' : '?'}t=${timestamp}` | |
| `${base}${path.slice(1)}${path.includes('?') ? '&' : '?'}t=${timestamp}` |
There was a problem hiding this comment.
Could you also please run the formatter after this change? Could change the suggestion
patak-dev
approved these changes
Jul 28, 2021
Shinigami92
approved these changes
Jul 28, 2021
patak-dev
changed the title
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
2 tasks
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request ensures the
baseis also used for HMR updates when a CSS file was included using alinktag.Additional context
baseis already being used to prefix the URLs when ajs-updateoccurs.Since the
baseis removed from theurlwhen registering a CSS file in the module graph, thepathsent in thecss-updatemessage is not prefixed withbase.As a result, the updated
hreftargets the origin root (/), which is not consistent with how JS updates are fetched, and requires special handling if proxying requests to the Vite dev server.What is the purpose of this pull request?