fix: skip fs fallback for out of root urls, fix #3364 #3431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3364, and other issues reported that were trying to access
/service-worker.js
.This PR reworks the fs fallback check and skips it instead of failing with a security error if the URL results in a file access that is not allowed (ie out of workspace root for the moment, but later it could mean that it is present in a blocklist).
This change only applies when the user sets
server.fsServe.strict
totrue
Additional context
The
isFileAccessAllowed
function may later contain more logic related to whitelist/blocklist so it is good that is already separated.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).